HTTPS test for sharded shuffle #1473
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This almost completes the setup for TLS/encryption infrastructure with one major exception - match key encryption keys are not re-used across shards. I have a PR almost ready, but decided to split that functionality to make PR somewhat revieweable
akoshelev
force-pushed
the
https-sharded-shuffle-test-2
branch
from
8db537b to
4f0296f
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1473 +/- ##
==========================================
- Coverage 93.86% 93.84% -0.02%
==========================================
Files 235 235
Lines 42451 42438 -13
==========================================
- Hits 39845 39826 -19
- Misses 2606 2612 +6 ☔ View full report in Codecov by Sentry. |
This was referenced Dec 4, 2024
eriktaubeneck
approved these changes
Dec 4, 2024
cberkhoff
approved these changes
Dec 4, 2024
| @@ -189,18 +185,39 @@ pub fn spawn_shards( | |||
| .args(["-i", &id.to_string()]) | |||
| .args(["--shard-index", &shard_index.to_string()]) | |||
| .args(["--shard-count", &shard_count.to_string()]) | |||
| .args(["--network".into(), config_path.join("network.toml")]) | |||
| .arg("--disable-https") | |||
There was a problem hiding this comment.
so this is the first time we have https tests?
There was a problem hiding this comment.
for sharded world yes
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This almost completes the setup for TLS/encryption infrastructure with one major exception - match key encryption keys are not re-used across shards. I have a PR almost ready, but decided to split that functionality to make PR somewhat revieweable